Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jshint & npm test script #57

Merged
merged 1 commit into from
Nov 8, 2015

Conversation

AndersDJohnson
Copy link
Contributor

Adding JSHint via Grunt, and npm test script.

This will help ensure we have valid and safe JS, especially through proposed changes.

Once this is in place, we can get CI integration and badges, e.g. Travis CI.

@addyosmani
Copy link
Member

Thanks for the PR. Given that we're just looking at linting here, can you replace the Grunt setup with a straight npm script?

@arthurvr
Copy link

arthurvr commented Oct 2, 2015

ping @adjohnson916 :)

@AndersDJohnson
Copy link
Contributor Author

@addyosmani @arthurvr I've switched this to a simple npm script using vanilla jshint as a dependency, removing the grunt file and dependency.

I've rebased the same branch and force pushed, though its name which includes "grunt" is now a misnomer, rather then create a new branch and PR, because it keeps things together better.

Note that there are JSHint warnings in the current code. If we merge this, I can follow up with fixes for that (e.g. #66 replacing #58). Would you then consider adding CI to check this, e.g. Travis CI?

AndersDJohnson pushed a commit to AndersDJohnson/umd that referenced this pull request Oct 10, 2015
AndersDJohnson pushed a commit to AndersDJohnson/umd that referenced this pull request Oct 10, 2015
@AndersDJohnson AndersDJohnson changed the title add grunt, jshint, and npm test script Oct 10, 2015
@EvanCarroll EvanCarroll merged commit bf3db45 into umdjs:master Nov 8, 2015
@AndersDJohnson
Copy link
Contributor Author

@EvanCarroll Thanks for merging!

@EvanCarroll
Copy link
Contributor

NP. patches will be easier to get in now. I'm going to help out with the project. Thank for the patience.

This was referenced Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants