-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing missed "CEPC" mentions and attribution error #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -760,7 +760,7 @@ <h2> | |||
</dt> | |||
<dd> | |||
<p> | |||
Language or behaviour that may appear kind or helpful but conveys a feeling of superiority or condescension. | |||
Language or behaviour that may appear kind or helpful but conveys a feeling of superiority or condescension. <cite><a href="https://languages.oup.com/">Adapted from the Oxford Languages Dictionary.</a></cite> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shame that access to the dictionary appears to be behind a paywall - the cited link is not to a dictionary but to a landing page for Oxford Languages. Not sure what change could improve that other than using a definition from a more open dictionary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can access the definition by googling "patronizing", which pops up the google dictionary feature powered by Oxford. There is a direct URL but it's a bit messy, I could use it though.
I did look at other definitions from sources like Merriam-Webster and Cambridge Dictionary, but felt this one captured the meaning most clearly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess a Google link may at some point in the future not resolve to Oxford Languages, since they could switch provider at any time. Hmm, tricky, I don't have a good alternative suggestion.
Recent merges accidentally added "CEPC" back into the document, I have fixed that.
Also added the missing attribution for "patronizing" as mentioned in issue #264.
Preview | Diff