Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase auth Email Action Links API #258

Merged
merged 7 commits into from
Feb 13, 2019

Conversation

hardikns
Copy link
Contributor

@hardikns hardikns commented Feb 8, 2019

Added generate_password_reset_link(),
generate_email_verification_link() and generate_email_sign_in_link()
methods to the auth API.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardikns, thanks for putting this together. We already have a reviewed and approved API proposal for this. Can you change you implementation to fit the following API signatures:

generate_password_reset_link(email, action_code_settings=None, app=None)
generate_email_verification_link(email, action_code_settings=None, app=None)
generate_sign_in_with_email_link(email, action_code_settings, app=None)

ActionCodeSettings(url, handle_code_in_app=None, ios_bundle_id=None, android_package_name=None, android_install_app=None, android_minimum_version=None, dynamic_link_domain=None)

I left a few other comments after taking a quick peek at the code. Once you've made the necessary changes to the API, I will take do a more thorough review.

firebase_admin/_user_mgt.py Outdated Show resolved Hide resolved
firebase_admin/_user_mgt.py Outdated Show resolved Hide resolved
firebase_admin/_auth_utils.py Outdated Show resolved Hide resolved
firebase_admin/_auth_utils.py Outdated Show resolved Hide resolved
firebase_admin/_auth_utils.py Outdated Show resolved Hide resolved
firebase_admin/_user_mgt.py Outdated Show resolved Hide resolved
firebase_admin/auth.py Outdated Show resolved Hide resolved
@hiranya911 hiranya911 self-assigned this Feb 8, 2019
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hardikns. The API looks correct. I've left a bunch of comments on the implementation -- mostly minor refactorings.

firebase_admin/_user_mgt.py Outdated Show resolved Hide resolved
firebase_admin/_user_mgt.py Outdated Show resolved Hide resolved
firebase_admin/_user_mgt.py Outdated Show resolved Hide resolved
firebase_admin/_user_mgt.py Outdated Show resolved Hide resolved
firebase_admin/_user_mgt.py Outdated Show resolved Hide resolved
integration/test_auth.py Outdated Show resolved Hide resolved
tests/test_user_mgt.py Outdated Show resolved Hide resolved
tests/test_user_mgt.py Outdated Show resolved Hide resolved
tests/test_user_mgt.py Outdated Show resolved Hide resolved
integration/test_auth.py Outdated Show resolved Hide resolved
@hardikns
Copy link
Contributor Author

@hiranya911 , Thanks. I will address these comments in couple of days.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@hardikns hardikns force-pushed the hs_email_action_links branch from 95beb1a to fc10c14 Compare February 12, 2019 17:09
@googlebot
Copy link

CLAs look good, thanks!

@hardikns
Copy link
Contributor Author

@hiranya911 , I think I have fixed all comments, but will re-review tomorrow.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hardikns. Looks pretty solid. Just a couple of nits in the integration tests and then I can merge this.

integration/test_auth.py Outdated Show resolved Hide resolved
integration/test_auth.py Outdated Show resolved Hide resolved
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardikns I'm approving this PR with a couple of suggestions for cosmetic improvements. I will merge the PR when those last bits are addressed. Thanks again for all your work on this PR.

integration/test_auth.py Outdated Show resolved Hide resolved
integration/test_auth.py Outdated Show resolved Hide resolved
integration/test_auth.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants