Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase auth Email Action Links API #258

Merged
merged 7 commits into from
Feb 13, 2019
Merged

Firebase auth Email Action Links API #258

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cf05c9b
added email action link generation to auth
hardikns Feb 7, 2019
221260b
added change log entry
hardikns Feb 7, 2019
2a74c1d
Integration tests added
hardikns Feb 7, 2019
8e7df34
fixed review comments
hardikns Feb 8, 2019
fc10c14
fixes for review comments
hardikns Feb 12, 2019
8b14cc2
minor tidy up - review comments
hardikns Feb 13, 2019
1a282e4
fixed cosmetic comments in IT
hardikns Feb 13, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed cosmetic comments in IT
  • Loading branch information
@hardikns
hardikns committed Feb 13, 2019
commit 1a282e41263b81572a3583ce38d1ae27986ef22e
6 changes: 3 additions & 3 deletions integration/test_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ def test_password_reset(new_user_email_unverified, api_key):
link = auth.generate_password_reset_link(new_user_email_unverified.email)
assert isinstance(link, six.string_types)
query_dict = _extract_link_params(link)
user_email = _reset_password(query_dict['oobCode'], "newPassword", api_key)
user_email = _reset_password(query_dict['oobCode'], 'newPassword', api_key)
assert new_user_email_unverified.email == user_email
# password reset also set email_verified to True
assert auth.get_user(new_user_email_unverified.uid).email_verified
Expand All @@ -439,7 +439,7 @@ def test_password_reset_with_settings(new_user_email_unverified, api_key):
assert isinstance(link, six.string_types)
query_dict = _extract_link_params(link)
assert query_dict['continueUrl'] == ACTION_LINK_CONTINUE_URL
user_email = _reset_password(query_dict['oobCode'], "newPassword", api_key)
user_email = _reset_password(query_dict['oobCode'], 'newPassword', api_key)
assert new_user_email_unverified.email == user_email
# password reset also set email_verified to True
assert auth.get_user(new_user_email_unverified.uid).email_verified
Expand All @@ -464,7 +464,7 @@ def test_email_sign_in_with_settings(new_user_email_unverified, api_key):
assert query_dict['continueUrl'] == ACTION_LINK_CONTINUE_URL
oob_code = query_dict['oobCode']
id_token = _sign_in_with_email_link(new_user_email_unverified.email, oob_code, api_key)
assert id_token
assert id_token is not None and len(id_token) > 0
assert auth.get_user(new_user_email_unverified.uid).email_verified

class CredentialWrapper(credentials.Base):
Expand Down