strip realtime change from test app

FirebaseRemoteConfig/Sources/FIRRemoteConfig.m

@@ -316,24 +316,25 @@ - (void)activateWithCompletion:(FIRRemoteConfigActivateChangeCompletion)completi
                                           toSource:RCNDBSourceActive
                                       forNamespace:self->_FIRNamespace];
     strongSelf->_settings.lastApplyTimeInterval = [[NSDate date] timeIntervalSince1970];
+    // New config has been activated at this point
     FIRLogDebug(kFIRLoggerRemoteConfig, @"I-RCN000069", @"Config activated.");
     [strongSelf->_configContent activatePersonalization];
-
+    dispatch_async(dispatch_get_main_queue(), ^{
+      [self notifyConfigHasChanged];
+    });
     // Update experiments only for 3p namespace
     NSString *namespace = [strongSelf->_FIRNamespace
         substringToIndex:[strongSelf->_FIRNamespace rangeOfString:@":"].location];
     if ([namespace isEqualToString:FIRNamespaceGoogleMobilePlatform]) {
       [strongSelf->_configExperiment updateExperimentsWithHandler:^(NSError *_Nullable error) {
         if (completion) {
-          [self notifyConfigHasChanged];
           dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
             completion(YES, nil);
           });
         }
       }];
     } else {
       if (completion) {
-        [self notifyConfigHasChanged];
         dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
           completion(YES, nil);
         });

FirebaseRemoteConfig/Tests/Sample/RemoteConfigSampleApp/ViewController.m

@@ -103,21 +103,10 @@ - (void)viewDidLoad {
       }
       FIRRemoteConfigSettings *settings = [[FIRRemoteConfigSettings alloc] init];
       settings.fetchTimeout = 300;
-      settings.minimumFetchInterval = 300;
+      settings.minimumFetchInterval = 0;
       ((FIRRemoteConfig *)(self.RCInstances[namespaceString][appString])).configSettings = settings;
     }
   }
-  // Add realtime listener for firebase namespace
-  [self.RCInstances[FIRNamespaceGoogleMobilePlatform][FIRDefaultFIRAppName]
-      addOnConfigUpdateListener:^(NSError *_Nullable error) {
-        if (error != nil) {
-          [[FRCLog sharedInstance]
-              logToConsole:[NSString
-                               stringWithFormat:@"Realtime Error: %@", error.localizedDescription]];
-        } else {
-          [[FRCLog sharedInstance] logToConsole:[NSString stringWithFormat:@"Config updated!"]];
-        }
-      }];
   [[FRCLog sharedInstance] logToConsole:@"RC instances inited"];
 
   self.namespacePicker.dataSource = self;

FirebaseRemoteConfigSwift/Apps/SwiftUISample/SwiftUISample/ContentView.swift

@@ -34,33 +34,13 @@ struct ContentView: View {
   @RemoteConfigProperty(key: "recipe", placeholder: Recipe(recipe_name: "banana bread", cook_time: 40, notes: "yum!")) var recipe : Recipe
 
   @State private var realtimeSwitch = false
-  @State private var currentRegister : FIRConfigUpdateListenerRegistration? = nil
   var realtimeToggle: Bool
 
   var body: some View {
     VStack {
       Button(action: fetchAndActivate) {
           Text("fetchAndActivate")
       }
-      Toggle("Real Time Switch", isOn: $realtimeSwitch)
-      .toggleStyle(.switch)
-      .onChange(of: realtimeSwitch) { value in
-        if (value) {
-          self.currentRegister = RemoteConfig.remoteConfig().add(onConfigUpdateListener: { error in
-            guard error == nil else {
-              return
-            }
-            RemoteConfig.remoteConfig().activate { changed, error in
-              guard error == nil && changed else {
-                return
-              }
-            }
-          })
-        }
-        else {
-          self.currentRegister?.remove()
-        }
-      }
 
       List(fruits, id: \.self) { fruit in
         Text(fruit)

FirebaseRemoteConfigSwift/Apps/SwiftUISample/SwiftUISample/SwiftUISampleApp.swift

@@ -28,18 +28,6 @@ class AppDelegate: NSObject, UIApplicationDelegate {
     settings.minimumFetchInterval = 0
     config.configSettings = settings
     try? config.setDefaults(from: ["mobileweek":["section 0": "Breakfast"]])
-
-
-    _ = RemoteConfig.remoteConfig().add(onConfigUpdateListener: { error in
-      guard error == nil else {
-        return
-      }
-      RemoteConfig.remoteConfig().activate { changed, error in
-        guard error == nil && changed else {
-          return
-        }
-      }
-    })
     return true
   }
 }

FirebaseRemoteConfigSwift/Sources/PropertyWrapper/RemoteConfigValueObservable.swift

@@ -18,8 +18,8 @@ import SwiftUI
 import FirebaseRemoteConfig
 
 extension Notification.Name {
-
-    static let onRemoteConfigChanged = Notification.Name("FIRRemoteConfigChangeNotification")
+  // Listens to FirebaseRemoteConfig SDK if new configs are activated.
+  static let onRemoteConfigChanged = Notification.Name("FIRRemoteConfigChangeNotification")
 }
 
 @available(iOS 14.0, macOS 11.0, macCatalyst 14.0, tvOS 14.0, watchOS 7.0, *)
@@ -28,7 +28,6 @@ internal class RemoteConfigValueObservable<T: Decodable>: ObservableObject {
   private let key: String
   private let remoteConfig: RemoteConfig
   private let fallbackValue : T
-  private var registration: FIRConfigUpdateListenerRegistration?
 
   init(key: String, fallbackValue: T) {
     self.key = key
@@ -59,8 +58,4 @@ internal class RemoteConfigValueObservable<T: Decodable>: ObservableObject {
     } catch {
     }
   }
-
-  deinit {
-    self.registration?.remove()
-  }
 }