Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Config Dynamic Property Wrapper #10155

Merged
merged 44 commits into from
Sep 23, 2022
Merged

Remote Config Dynamic Property Wrapper #10155

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
b21aba3
add config property wrapper
charlotteliang Jul 29, 2022
c477a2c
update podspec
charlotteliang Jul 29, 2022
8d574a5
add update gitignore
charlotteliang Jul 29, 2022
a4f33f3
add a swiftUI sample app to test property wrapper
charlotteliang Jul 29, 2022
04336ce
remove the multiple app case
charlotteliang Jul 29, 2022
c4a3cab
test all types of configs
charlotteliang Aug 3, 2022
f11c629
add Shared swift library to pod file
charlotteliang Aug 3, 2022
d88d8b2
clang-format
charlotteliang Aug 3, 2022
f9afb34
update project version
charlotteliang Aug 19, 2022
5e39c3a
follow swift api guidline and use key instead forKey
charlotteliang Aug 19, 2022
b0c4506
fix the crash when config value is empty
charlotteliang Aug 22, 2022
6498227
work out a way to mark property wrapper optional
charlotteliang Aug 24, 2022
316098d
add unit test
charlotteliang Aug 24, 2022
c50acea
add test case for dict and array
charlotteliang Aug 24, 2022
2b4d0a4
make the parameter optional
charlotteliang Aug 24, 2022
ad7d49c
adding placeholder parameter
charlotteliang Aug 24, 2022
8ad720a
add unit test for placeholder value and ensure default cache remote v…
charlotteliang Aug 26, 2022
ba12e0d
add more unit tests that covers the placeholder and default value tes…
charlotteliang Aug 26, 2022
121e771
[RC] Fix retry logic to respect max retry count (#10143)
karenyz Aug 26, 2022
d5b5cf5
ensure only update property wrapper when activate is true
charlotteliang Aug 26, 2022
21fc62f
update property wrapper when config is activated
charlotteliang Aug 31, 2022
bb6685b
cleanup
charlotteliang Aug 31, 2022
8bbe196
strip realtime change from test app
charlotteliang Sep 1, 2022
d7af202
update based on API review feedback
charlotteliang Sep 3, 2022
a5df4d6
swift-format
charlotteliang Sep 3, 2022
312c53b
update changelog
charlotteliang Sep 7, 2022
1af5047
rename the notification to be specific to activation change
charlotteliang Sep 7, 2022
3f09d0f
Apply suggestions from code review
charlotteliang Sep 8, 2022
1efca9e
send project id to ensure it is for default project
charlotteliang Sep 9, 2022
6fe6c4f
merge conflict
charlotteliang Sep 9, 2022
c34d975
swiftformat
charlotteliang Sep 9, 2022
aa5ee90
fix test failure and also update a comment on hanlding decoding error
charlotteliang Sep 9, 2022
c42def4
fix default config text failure
charlotteliang Sep 10, 2022
fee4ce0
use app name as the unique identifier to each firebase app instance
charlotteliang Sep 14, 2022
9961b63
use camel case in stead of snake case for the parameters name
charlotteliang Sep 14, 2022
669fe7a
add swiftUI dependency because we use dynamic property wrapper
charlotteliang Sep 14, 2022
108fc9d
move to framework
charlotteliang Sep 14, 2022
2b3cce0
bump os version
charlotteliang Sep 19, 2022
40804aa
make tvos version consistent with ios
charlotteliang Sep 19, 2022
cd7b148
revert watchos version and disable rc console test
charlotteliang Sep 21, 2022
e6ffaaf
reenable console test but remove tests from api tests
charlotteliang Sep 22, 2022
d52a711
resolve conflicts and update changelog
charlotteliang Sep 22, 2022
fe13278
use distinct key for the default config test to ensure it is not polu…
charlotteliang Sep 22, 2022
e8e11a7
exclude tests that requires fetch and activate because devices cached…
charlotteliang Sep 22, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert watchos version and disable rc console test
  • Loading branch information
@charlotteliang
charlotteliang committed Sep 21, 2022
commit cd7b1482814608b75cdc73b10d4d484492b205fd
5 changes: 3 additions & 2 deletions .github/workflows/remoteconfig.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ jobs:
- name: Fake Console API Tests
run: scripts/third_party/travis/retry.sh scripts/build.sh RemoteConfig iOS fakeconsole
- name: IntegrationTest
if: matrix.target == 'iOS'
# disable console test
#if: matrix.target == 'iOS'
# No retry to avoid exhausting AccessToken quota.
run: ([ -z $plist_secret ] || scripts/build.sh RemoteConfig iOS integration)
# run: ([ -z $plist_secret ] || scripts/build.sh RemoteConfig iOS integration)

pod-lib-lint:
# Don't run on private repo unless it is a PR.
Expand Down
2 changes: 1 addition & 1 deletion FirebaseRemoteConfigSwift.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ app update.
ios_deployment_target = '11.0'
osx_deployment_target = '10.12'
tvos_deployment_target = '11.0'
watchos_deployment_target = '7.0'
watchos_deployment_target = '6.0'

s.ios.deployment_target = ios_deployment_target
s.osx.deployment_target = osx_deployment_target
Expand Down