Fix for #1491: Disable use of $httpHeaders in browser extensions too. #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
|
I still see permission issue after applying this PR. FWIW, |
Turns out I did not signin first..after sign in it worked fine. |
|
FYI- Based on #1491 (comment) I tweaked the isBrowserExtension() implementation... I'll try to verify it a bit better today. |
hsubox76
reviewed
Jan 14, 2020
|
Verified this returns the correct value in and out of a Chrome or Firefox extension. |
wilhuff
reviewed
Jan 14, 2020
hsubox76
approved these changes
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2464.
@wu-hui Can you test this with your repro extension?
@wilhuff Can you review?
@hsubox76 Can you review the util changes?