Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial user object implementation #2896

Merged
merged 7 commits into from
Apr 14, 2020
Merged

Add initial user object implementation #2896

merged 7 commits into from
Apr 14, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Apr 10, 2020

No description provided.

@sam-gc sam-gc marked this pull request as ready for review April 10, 2020 19:24
avolkovi
avolkovi reviewed Apr 10, 2020
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
avolkovi
avolkovi reviewed Apr 10, 2020
View reviewed changes
packages-exp/auth-exp/test/mock_auth.ts

import { AppName, ApiKey, Auth } from '../src/model/auth';

export function mockAuth(name: AppName, apiKey: ApiKey): Auth {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have something similar in my api_helper branch...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for yours to merge and use it
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 10, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (a627ebf) and head commit (e26900d).

Test Logs
@avolkovi avolkovi mentioned this pull request Apr 10, 2020
Merged
@sam-gc sam-gc merged commit 2e1ee91 into auth-next Apr 14, 2020
avolkovi pushed a commit that referenced this pull request Apr 22, 2020
@sam-gc @avolkovi
Add initial user object implementation (#2896)
65444de 
* Initial user object implementation
avolkovi pushed a commit that referenced this pull request Apr 23, 2020
@sam-gc @avolkovi
Add initial user object implementation (#2896)
ade1841 
* Initial user object implementation
avolkovi pushed a commit that referenced this pull request Apr 24, 2020
@sam-gc @avolkovi
Add initial user object implementation (#2896)
33d2c77 
* Initial user object implementation
@firebase firebase locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@sam-gc @google-oss-bot @avolkovi @Feiyang1