Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2393 #3160

Closed
wants to merge 4 commits into from
Closed

Issue 2393 #3160

wants to merge 4 commits into from

Conversation

XuechunHou
Copy link
Contributor

a fix for issue #2393 on performance and remote-config module.

Throw runtime error (UNSUPPORTED_BROWSER) on initialization of the instance when IndexedDB is not supported in some browser situations.

The fix is tested on Safari and Firefox private window rendering iframe with https://github.com/tomsun/firebase-js-sdk-securityerror-example provided in the issue conversation.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/performance

    Type Base (5c41eab) Head (309ff37) Diff
    browser 26.7 kB 27.7 kB +974 B (+3.7%)
    esm2017 24.7 kB 25.7 kB +974 B (+3.9%)
    main 26.7 kB 27.7 kB +974 B (+3.7%)
    module 26.4 kB 27.4 kB +974 B (+3.7%)
  • @firebase/remote-config

    Type Base (5c41eab) Head (309ff37) Diff
    browser 23.1 kB 24.1 kB +974 B (+4.2%)
    esm2017 17.7 kB 18.7 kB +974 B (+5.5%)
    main 23.1 kB 24.1 kB +974 B (+4.2%)
    module 22.7 kB 23.7 kB +974 B (+4.3%)
  • firebase

    Type Base (5c41eab) Head (309ff37) Diff
    firebase-performance-standalone.es2017.js 72.0 kB 72.7 kB +736 B (+1.0%)
    firebase-performance-standalone.js 47.4 kB 48.2 kB +745 B (+1.6%)
    firebase-performance.js 37.8 kB 38.6 kB +745 B (+2.0%)
    firebase-remote-config.js 37.0 kB 37.7 kB +742 B (+2.0%)
    firebase.js 823 kB 824 kB +1.49 kB (+0.2%)

Test Logs

@XuechunHou XuechunHou closed this Jul 16, 2020
@XuechunHou XuechunHou deleted the issue-2393 branch July 16, 2020 21:14
@firebase firebase locked and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.