Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw from connection.send in Node.js #5578

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Do not throw from connection.send in Node.js #5578

merged 4 commits into from
Oct 6, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Oct 5, 2021

Fixes #5372
We should not throw from connection.send to enable retries.
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: af06fdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/storage Patch
firebase Patch
@firebase/storage-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@Feiyang1 Feiyang1 requested a review from egilmorez as a code owner October 5, 2021 22:11
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 5, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/storage

    Type Base (e456d00) Head (6cbc3cd) Diff
    main 53.5 kB 53.6 kB +75 B (+0.1%)

  • firebase

    Type Base (e456d00) Head (6cbc3cd) Diff
    firebase-storage.js 140 kB 140 kB +128 B (+0.1%)

Test Logs
schmidt-sebastian
schmidt-sebastian reviewed Oct 5, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I rewrote this here - https://github.com/firebase/firebase-js-sdk/pull/4973/files#diff-12013303701640021d24263089ec56052d40f6408d413dc10d78610499706fe2R56
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 5, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (e456d00) and head commit (6cbc3cd).
@Feiyang1
Copy link
Member Author

Feiyang1 commented Oct 5, 2021

@schmidt-sebastian Nice! Definitely agree with using async await here. Since you have started the refactoring in the other PR, I will leave this PR as is and let your PR change it.

Also added a couple of test cases if you'd like to review.
schmidt-sebastian
schmidt-sebastian approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases LGTM as well.
packages/storage/test/browser/connection.test.ts Outdated Show resolved Hide resolved
@Feiyang1 Feiyang1 merged commit a7e00b9 into master Oct 6, 2021
@Feiyang1 Feiyang1 deleted the fei-storage-network branch October 6, 2021 18:02
@google-oss-bot google-oss-bot mentioned this pull request Oct 12, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes
4 participants
@Feiyang1 @google-oss-bot @schmidt-sebastian @hsubox76