Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw from connection.send in Node.js #5578

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Do not throw from connection.send in Node.js #5578

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b18da78
do not throw from connection.send
Feiyang1 Oct 5, 2021
97a6889
Create curvy-peaches-deliver.md
Feiyang1 Oct 5, 2021
42ea7fc
add tests
Feiyang1 Oct 5, 2021
af06fdc
formatting
Feiyang1 Oct 6, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
formatting
  • Loading branch information
@Feiyang1
Feiyang1 committed Oct 6, 2021
commit af06fdc028047fb2581ce2eba050a67fcaff3bb9
4 changes: 2 additions & 2 deletions packages/storage/test/browser/connection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ describe('Connections', () => {
const fakeXHR = useFakeXMLHttpRequest();
const connection = new XhrConnection();
const sendPromise = connection.send('testurl', 'GET');
// simulate an network error
// simulate a network error
((connection as any).xhr_ as SinonFakeXMLHttpRequest).error();
await sendPromise;
expect(connection.getErrorCode()).to.equal(ErrorCode.NETWORK_ERROR);
fakeXHR.restore();
});
});
});