Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where pause throws an error #6938

Merged
merged 16 commits into from
Jan 13, 2023
Merged

Conversation

maneesht
Copy link
Contributor

Fixes #6935

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: 3d2b48a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/storage Patch
firebase Patch
@firebase/storage-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 10, 2023

Size Report 1

Affected Products

  • @firebase/database

    TypeBase (50b8191)Merge (d0b0c5a)Diff
    browser247 kB247 kB+2 B (+0.0%)
    esm5276 kB276 kB+2 B (+0.0%)
    main281 kB281 kB+2 B (+0.0%)
    module247 kB247 kB+2 B (+0.0%)
  • @firebase/database-compat/standalone

    TypeBase (50b8191)Merge (d0b0c5a)Diff
    main370 kB370 kB+2 B (+0.0%)
  • @firebase/storage

    TypeBase (50b8191)Merge (d0b0c5a)Diff
    browser56.0 kB56.0 kB-2 B (-0.0%)
    esm562.5 kB62.5 kB-2 B (-0.0%)
    main58.5 kB58.5 kB-2 B (-0.0%)
    module56.0 kB56.0 kB-2 B (-0.0%)
  • bundle

    17 size changes

    TypeBase (50b8191)Merge (d0b0c5a)Diff
    database (Append to a list of data)148 kB148 kB+2 B (+0.0%)
    database (Filtering data)147 kB147 kB+2 B (+0.0%)
    database (Listen for child events)163 kB163 kB+2 B (+0.0%)
    database (Listen for value events + Detach listeners)163 kB163 kB+2 B (+0.0%)
    database (Listen for value events)163 kB163 kB+2 B (+0.0%)
    database (Read data once)163 kB163 kB+2 B (+0.0%)
    database (Save data as transactions)165 kB165 kB+2 B (+0.0%)
    database (Sort data)148 kB148 kB+2 B (+0.0%)
    database (Write data)147 kB147 kB+2 B (+0.0%)
    storage (getBytes)40.1 kB40.1 kB-2 B (-0.0%)
    storage (getDownloadURL)42.1 kB42.1 kB-2 B (-0.0%)
    storage (getMetadata)41.6 kB41.6 kB-2 B (-0.0%)
    storage (list + listAll)41.0 kB41.0 kB-2 B (-0.0%)
    storage (updateMetadata)41.8 kB41.8 kB-2 B (-0.0%)
    storage (uploadBytes)46.9 kB46.9 kB-2 B (-0.0%)
    storage (uploadBytesResumable)56.9 kB56.9 kB-2 B (-0.0%)
    storage (uploadString)47.2 kB47.2 kB-2 B (-0.0%)

  • firebase

    TypeBase (50b8191)Merge (d0b0c5a)Diff
    firebase-compat.js746 kB746 kB-1 B (-0.0%)
    firebase-database-compat.js165 kB165 kB+2 B (+0.0%)
    firebase-database.js154 kB154 kB+2 B (+0.0%)
    firebase-storage-compat.js40.3 kB40.2 kB-3 B (-0.0%)
    firebase-storage.js39.1 kB39.1 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KshsCghB3l.html
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 10, 2023

Size Analysis Report 1

Affected Products

  • @firebase/database

    • DataSnapshot

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size117 kB117 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • Database

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size115 kB115 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • OnDisconnect

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size119 kB119 kB+2 B (+0.0%)
      size-with-ext-deps141 kB141 kB+2 B (+0.0%)
    • QueryConstraint

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • TransactionResult

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _QueryImpl

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size115 kB115 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _QueryParams

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size115 kB115 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _ReferenceImpl

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size115 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _TEST_ACCESS_forceRestClient

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _TEST_ACCESS_hijackHash

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _repoManagerDatabaseFromApp

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _setSDKVersion

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size115 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _validatePathString

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • _validateWritablePath

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • child

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • connectDatabaseEmulator

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • enableLogging

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • endAt

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size118 kB118 kB+2 B (+0.0%)
      size-with-ext-deps139 kB139 kB+2 B (+0.0%)
    • endBefore

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size118 kB118 kB+2 B (+0.0%)
      size-with-ext-deps139 kB139 kB+2 B (+0.0%)
    • equalTo

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size119 kB119 kB+2 B (+0.0%)
      size-with-ext-deps140 kB140 kB+2 B (+0.0%)
    • forceLongPolling

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • forceWebSockets

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • get

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size132 kB132 kB+2 B (+0.0%)
      size-with-ext-deps154 kB154 kB+2 B (+0.0%)
    • getDatabase

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size117 kB117 kB+2 B (+0.0%)
      size-with-ext-deps146 kB146 kB+2 B (+0.0%)
    • goOffline

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • goOnline

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • increment

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • limitToFirst

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • limitToLast

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • off

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size124 kB124 kB+2 B (+0.0%)
      size-with-ext-deps145 kB145 kB+2 B (+0.0%)
    • onChildAdded

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size133 kB133 kB+2 B (+0.0%)
      size-with-ext-deps154 kB154 kB+2 B (+0.0%)
    • onChildChanged

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size133 kB133 kB+2 B (+0.0%)
      size-with-ext-deps154 kB154 kB+2 B (+0.0%)
    • onChildMoved

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size133 kB133 kB+2 B (+0.0%)
      size-with-ext-deps154 kB154 kB+2 B (+0.0%)
    • onChildRemoved

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size133 kB133 kB+2 B (+0.0%)
      size-with-ext-deps154 kB154 kB+2 B (+0.0%)
    • onDisconnect

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size120 kB120 kB+2 B (+0.0%)
      size-with-ext-deps141 kB141 kB+2 B (+0.0%)
    • onValue

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size133 kB133 kB+2 B (+0.0%)
      size-with-ext-deps154 kB154 kB+2 B (+0.0%)
    • orderByChild

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size118 kB118 kB+2 B (+0.0%)
      size-with-ext-deps139 kB139 kB+2 B (+0.0%)
    • orderByKey

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size117 kB117 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • orderByPriority

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size117 kB117 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • orderByValue

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size117 kB117 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • push

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size118 kB118 kB+2 B (+0.0%)
      size-with-ext-deps139 kB139 kB+2 B (+0.0%)
    • query

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • ref

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • refFromURL

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • remove

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • runTransaction

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size135 kB135 kB+2 B (+0.0%)
      size-with-ext-deps156 kB156 kB+2 B (+0.0%)
    • serverTimestamp

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps137 kB137 kB+2 B (+0.0%)
    • set

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size116 kB116 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • setPriority

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size117 kB117 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • setWithPriority

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size117 kB117 kB+2 B (+0.0%)
      size-with-ext-deps138 kB138 kB+2 B (+0.0%)
    • startAfter

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size118 kB118 kB+2 B (+0.0%)
      size-with-ext-deps139 kB139 kB+2 B (+0.0%)
    • startAt

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size118 kB118 kB+2 B (+0.0%)
      size-with-ext-deps139 kB139 kB+2 B (+0.0%)
    • update

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size118 kB118 kB+2 B (+0.0%)
      size-with-ext-deps139 kB139 kB+2 B (+0.0%)
  • @firebase/storage

    • StringFormat

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.1 kB10.1 kB-2 B (-0.0%)
      size-with-ext-deps27.1 kB27.1 kB-2 B (-0.0%)
    • _FbsBlob

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size14.4 kB14.4 kB-2 B (-0.0%)
      size-with-ext-deps32.4 kB32.4 kB-2 B (-0.0%)
    • _Location

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.1 kB10.1 kB-2 B (-0.0%)
      size-with-ext-deps27.0 kB27.0 kB-2 B (-0.0%)
    • _TaskEvent

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.1 kB10.1 kB-2 B (-0.0%)
      size-with-ext-deps27.0 kB27.0 kB-2 B (-0.0%)
    • _TaskState

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.2 kB10.2 kB-2 B (-0.0%)
      size-with-ext-deps27.1 kB27.1 kB-2 B (-0.0%)
    • _UploadTask

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size29.9 kB29.9 kB-2 B (-0.0%)
      size-with-ext-deps47.9 kB47.9 kB-2 B (-0.0%)
    • _dataFromString

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size12.6 kB12.6 kB-2 B (-0.0%)
      size-with-ext-deps29.5 kB29.5 kB-2 B (-0.0%)
    • _getChild

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.3 kB10.3 kB-2 B (-0.0%)
      size-with-ext-deps27.2 kB27.2 kB-2 B (-0.0%)
    • _invalidArgument

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.1 kB10.1 kB-2 B (-0.0%)
      size-with-ext-deps27.0 kB27.0 kB-2 B (-0.0%)
    • _invalidRootOperation

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.1 kB10.1 kB-2 B (-0.0%)
      size-with-ext-deps27.0 kB27.0 kB-2 B (-0.0%)
    • connectStorageEmulator

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.3 kB10.3 kB-2 B (-0.0%)
      size-with-ext-deps27.8 kB27.8 kB-2 B (-0.0%)
    • deleteObject

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size13.4 kB13.4 kB-2 B (-0.0%)
      size-with-ext-deps30.4 kB30.4 kB-2 B (-0.0%)
    • getBlob

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size13.5 kB13.5 kB-2 B (-0.0%)
      size-with-ext-deps30.5 kB30.5 kB-2 B (-0.0%)
    • getBytes

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size13.5 kB13.5 kB-2 B (-0.0%)
      size-with-ext-deps30.5 kB30.5 kB-2 B (-0.0%)
    • getDownloadURL

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size15.5 kB15.5 kB-2 B (-0.0%)
      size-with-ext-deps32.6 kB32.6 kB-2 B (-0.0%)
    • getMetadata

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size15.0 kB15.0 kB-2 B (-0.0%)
      size-with-ext-deps32.0 kB32.0 kB-2 B (-0.0%)
    • getStorage

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.5 kB10.5 kB-2 B (-0.0%)
      size-with-ext-deps35.7 kB35.7 kB-2 B (-0.0%)
    • getStream

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.1 kB10.1 kB-2 B (-0.0%)
      size-with-ext-deps27.1 kB27.1 kB-2 B (-0.0%)
    • list

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size14.1 kB14.1 kB-2 B (-0.0%)
      size-with-ext-deps31.1 kB31.1 kB-2 B (-0.0%)
    • listAll

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size14.4 kB14.4 kB-2 B (-0.0%)
      size-with-ext-deps31.4 kB31.4 kB-2 B (-0.0%)
    • ref

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size10.9 kB10.9 kB-2 B (-0.0%)
      size-with-ext-deps27.9 kB27.9 kB-2 B (-0.0%)
    • updateMetadata

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size15.3 kB15.3 kB-2 B (-0.0%)
      size-with-ext-deps32.3 kB32.3 kB-2 B (-0.0%)
    • uploadBytes

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size20.1 kB20.1 kB-2 B (-0.0%)
      size-with-ext-deps38.2 kB38.2 kB-2 B (-0.0%)
    • uploadBytesResumable

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size30.1 kB30.1 kB-2 B (-0.0%)
      size-with-ext-deps48.2 kB48.2 kB-2 B (-0.0%)
    • uploadString

      Size

      TypeBase (50b8191)Merge (141c333)Diff
      size20.3 kB20.3 kB-2 B (-0.0%)
      size-with-ext-deps38.4 kB38.4 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TGsl5kD8xA.html
@maneesht maneesht marked this pull request as ready for review January 11, 2023 18:45
@maneesht maneesht requested a review from egilmorez as a code owner January 11, 2023 18:45
Copy link

@tonyjhuang tonyjhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment

packages/storage/test/unit/task.test.ts Show resolved Hide resolved
@maneesht maneesht merged commit a67eb5d into master Jan 13, 2023
@maneesht maneesht deleted the mtewani/storage-fix-pause branch January 13, 2023 17:36
@google-oss-bot google-oss-bot mentioned this pull request Jan 17, 2023
@firebase firebase locked and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants