Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where pause throws an error #6938

Merged
merged 16 commits into from
Jan 13, 2023
Merged

Fixed issue where pause throws an error #6938

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d8bb500
Fixed issue where pause didn't work
maneesht Jan 10, 2023
90cce86
Removed console log
maneesht Jan 10, 2023
95be1ef
Create eleven-cycles-hang.md
maneesht Jan 10, 2023
11c164e
WIP
maneesht Jan 10, 2023
87ca416
Merge branch 'mtewani/storage-fix-pause' of https://github.com/fireba…
maneesht Jan 10, 2023
7bf749c
Added unit test. Stil WIP
maneesht Jan 11, 2023
6b7698b
Cleaned up tests a bit
maneesht Jan 11, 2023
cb37e84
Formatting
maneesht Jan 11, 2023
8ce7a46
More cleanpu
maneesht Jan 11, 2023
e172faf
Fixed linting
maneesht Jan 11, 2023
b98a71d
Cleaned up naming
maneesht Jan 11, 2023
9148efe
Fixed linting
maneesht Jan 11, 2023
70ee6c1
Replaced timeout
maneesht Jan 11, 2023
2c4bed9
Fixed bug again
maneesht Jan 11, 2023
fc80cf1
Added a comment
maneesht Jan 13, 2023
3d2b48a
Amended comment
maneesht Jan 13, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed console log
  • Loading branch information
@maneesht
maneesht committed Jan 10, 2023
commit 90cce8618d77034684e38fab842151aa66d54ebc
1 change: 0 additions & 1 deletion packages/storage/test/integration/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ describe('FirebaseStorage Exp', () => {
snapshot => {
const p = [snapshot.bytesTransferred, snapshot.totalBytes];
if (snapshot.bytesTransferred > 0 && !hasPaused) {
console.log('pausing');
task.pause();
hasPaused = true;
}
Expand Down